Make actions use target=this implicitly
#14479
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
I added a test. |
rwjblue
requested changes
Oct 17, 2016
| <button {{action this 'foo'}}> | ||
| <button onblur={{action this 'foo'}}> | ||
| <button onblur={{action this (action this 'foo') 'bar'}}> | ||
| <button {{action target=this 'foo'}}> |
There was a problem hiding this comment.
This isn't quite right, the hash has to be after positional args...
sukima
reviewed
Oct 18, 2016
| <button onblur={{action this (action this 'foo') 'bar'}}> | ||
| <button {{action target=this 'foo'}}> | ||
| <button onblur={{action target=this 'foo'}}> | ||
| <button onblur={{action target=this (action target=this 'foo') 'bar'}}> |
There was a problem hiding this comment.
Yes; it has been corrected.
| } | ||
|
|
||
| return false; | ||
| } |
There was a problem hiding this comment.
This function is unfortunately repeated. @rwjblue should the util function be DRY somewhere? And if so where?
sukima
reviewed
Oct 18, 2016
| if (pair.key === key) { | ||
| return pair; | ||
| } | ||
| } |
There was a problem hiding this comment.
This function is unfortunately repeated. @rwjblue should the util function be DRY somewhere? And if so where?
There was a problem hiding this comment.
I will extract it and then make another PR to update other refs.
zackthehuman
force-pushed
the
action-this-ast
branch
from
45ec17b to
ffbc7bf
Compare
|
@zackthehuman is this ready for a new review? Thank you! |
|
@zackthehuman thank you! |
4 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This addresses the bug in #14469. Might need a new test. Please review @rwjblue @chancancode.